Repository navigation
feat: secure browser onboarding and bounded review context - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds browser onboarding and connection management behind
WEB_ENABLED=false, together with bounded review-context exploration and clearer native review summaries. Existing CLI connections, OIDC/workflow identity checks, isolated Docker execution, tenant authorization, quotas and non-approving fallback publication are retained.Implemented flow: GitHub OAuth with PKCE and browser-bound state, native installation/repository reconciliation, administrator/capability checks, protected Environments, idempotent setup/configuration PRs, registered-client ChatGPT OAuth, encrypted credential provisioning/recovery, API-key connection, reconnect/disconnect and live readiness. Configuration proposals preserve existing YAML comments and unchanged workflows.
Security-sensitive decisions:
Validation:
npm run checkpasses all 170 tests (zero skipped), typecheck, lint and build. Clean-checkout npm ci/check, actual workerd/D1, Chromium onboarding, pinned model catalog, Actionlint, npm audit (zero vulnerabilities), Docker build and actual pinned Codex synthetic-provider isolation tests pass. Trivy reports no High/Critical vulnerabilities; Wrangler dry-run passes. Scripted provider tests establish protocol/tool execution, not new live AI quality or website-provider acceptance.Rollout requires additive migration
0004_web_onboarding.sql, actual registered OAuth values/secrets and native installer consent for setup permissions. Keep browser activation and automatic merge disabled until operator acceptance. After this source PR is normally merged,scripts/prepare-pin-upgrade.mjs --source-pr NUMBER --caller OWNER/REPOSITORYderives the actual merge SHA and prepares the coordinated Worker/test and caller pin PRs. Existing pins are deliberately unchanged here; no guessed SHA or mutable reference is introduced.See
docs/web-onboarding.mdfor the threat boundary, configuration, acceptance matrix and activation/rollback procedure;docs/adaptive-context.mdfor context limits and opt-in quality evaluation. No production deployment, migration, settings/secret/session changes, real inference or PR merge was performed.